PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When developing F-Droid flavor, the IDE doesn't provide autocompletion and pretty much any other support.

Causes

We're relying on explicit environment variables or invoked task name to figure out whether we should configure F-Droid or not.

The IDE doesn't se these when communicating with Gradle.

Solutions

Just set everything so it works statically, without depending on env variables or tasks being run.

F-Droid flavor is always dependent on prod and foss source sets.
Each other non-free flavor is always dependent on nonfree.

So it looks like this:

%%{init: { "flowchart": { "curve": "linear" } } }%%
flowchart TD
    F(fdroid flavor) --> foss
    F --> p
    P(prod flavor) --> p(prod)
    P --> nonfree
    B(beta flavor) --> beta
    B --> nonfree
    I(internal flavor) --> internal
    I --> nonfree
    D(dev flavor) --> dev
    D --> nonfree
    S(staging flavor) --> nonfree
    S --> staging

Logs during Gradle configuration:

Adding non-free sourceSets to 'prod' flavor
Adding non-free sourceSets to 'internal' flavor
Adding non-free sourceSets to 'staging' flavor
Adding non-free sourceSets to 'beta' flavor
Adding non-free sourceSets to 'dev' flavor
Adding FOSS sourceSets to 'fdroid' flavor
Adding nonfree libraries to 'prod' flavor
Adding nonfree libraries to 'internal' flavor
Adding nonfree libraries to 'staging' flavor
Adding nonfree libraries to 'beta' flavor
Adding nonfree libraries to 'dev' flavor
Skipping nonfree libraries for 'fdroid' flavor

Attachments

When selecting prodDebug build type in the IDE:

When selecting fdroidDebug build type in the IDE:

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.